-
Notifications
You must be signed in to change notification settings - Fork 321
[moe fp8 training] fused reduction kernel along dim1 for 3d expert weights in backward #2865
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
danielvegamyhre
wants to merge
1
commit into
danielvegamyhre/stack/58
Choose a base branch
from
danielvegamyhre/stack/59
base: danielvegamyhre/stack/58
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/2865
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (3 Unrelated Failures)As of commit 3beaedf with merge base 253d65a ( BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
danielvegamyhre
added a commit
that referenced
this pull request
Aug 23, 2025
…ights in backward stack-info: PR: #2865, branch: danielvegamyhre/stack/59
3848c56
to
cf93326
Compare
2cdfdfe
to
1418745
Compare
danielvegamyhre
added a commit
that referenced
this pull request
Aug 24, 2025
…ights in backward stack-info: PR: #2865, branch: danielvegamyhre/stack/59
1418745
to
15fd988
Compare
…ights in backward stack-info: PR: #2865, branch: danielvegamyhre/stack/59
15fd988
to
3beaedf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
topic: not user facing
Use this tag if you don't want this PR to show up in release notes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked PRs:
[moe fp8 training] fused reduction kernel along dim1 for 3d expert weights in backward
Summary
grad_input = grad_output @ weight
using 1 single fused kernel with a reduction based approach to calculate scales, rather than 2 stage approach with atomics.Benchmarks