Skip to content

release notes script: keep not user facing rows #2875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 26, 2025
+2 −2
Merged

release notes script: keep not user facing rows #2875

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions scripts/clean_release_notes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,7 @@
"topic: performance": "Performance",
"topic: documentation": "Documentation",
"topic: for developer": "Developers",
"topic: not user facing": "Not User Facing",
}


Expand Down Expand Up @@ -123,6 +124,7 @@ def clean_release_notes():
"Performance": [],
"Documentation": [],
"Developers": [],
"Not User Facing": [],
}
with open(input_file, "r") as in_f, open(output_file, "a") as out_f:
for line in in_f.readlines():
Expand Down Expand Up @@ -195,8 +197,6 @@ def get_commit_category(
pr_number = parse_pr_number(commit_line)
if pr_number in pr_number_to_label:
label = pr_number_to_label[pr_number]
if label == "topic: not user facing":
return None
if label in GITHUB_LABEL_TO_CATEGORY:
return GITHUB_LABEL_TO_CATEGORY[label]
elif any(x in commit_line.lower() for x in ["revert", "version.txt"]):
Expand Down
Loading