-
Notifications
You must be signed in to change notification settings - Fork 537
[executorch][android] Add Runtime.java to centralize native library l… #10672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[executorch][android] Add Runtime.java to centralize native library l… #10672
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10672
Note: Links to docs will display an error until the docs builds have been completed. ❌ 3 New FailuresAs of commit a6486e6 with merge base 94f7b10 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
This PR needs a
|
Hi @LefterisXefteris could you please sign the CLA? |
I didn't see NativePeer.java updated. |
return initialized; | ||
} | ||
|
||
@DoNotStrip |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't have implementation yet. Please don't add that.
@@ -0,0 +1,28 @@ | |||
package org.pytorch.executorch; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a license template
This pull request addresses #10439 by introducing a Runtime.java class to centralize the loading of the native libexecutorch.so library on Android.
What’s Included
• Added Runtime.java in org.pytorch.executorch with a static loader block
• Updated NativePeer.java and LlmModule.java to defer initialization to Runtime.isInitialized()
• Added RuntimeTest.java to verify proper initialization