Skip to content

unbreak lintrunner in backends/arm #12075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 28, 2025
+15 −5
Merged

unbreak lintrunner in backends/arm #12075

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion backends/arm/_passes/decompose_sqrt_pass.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@
# LICENSE file in the root directory of this source tree.

# pyre-unsafe
from typing import Tuple, Union

import torch
from executorch.exir.dialects._ops import ops as exir_ops
from executorch.exir.pass_base import ExportPass
Expand All @@ -15,7 +17,7 @@
)


def get_sqrt_decomposition(op) -> tuple:
def get_sqrt_decomposition(op) -> Union[Tuple, torch._ops.OpOverload]:
# TODO : "MLETORCH-863 : Replace current sqrt -> pow.Tensor_Scalar workaround with pow.Tensor_Tensor"
if op in edge_sqrt_ops:
return exir_ops.edge.aten.pow.Tensor_Scalar
Expand Down
7 changes: 5 additions & 2 deletions backends/arm/_passes/replace_scalar_with_tensor_pass.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
# pyre-unsafe


from typing import Dict
from typing import Dict, Union

import torch
from executorch.backends.transforms.replace_scalar_with_tensor import (
Expand All @@ -18,7 +18,10 @@


# Operators that are included for both TOSA profiles
_common_ops: Dict[EdgeOpOverload, EdgeOpOverload] = {
_common_ops: Dict[
Union[EdgeOpOverload, torch._ops.OpOverload],
Union[EdgeOpOverload, torch._ops.OpOverload],
] = {
exir_ops.edge.aten.add.Scalar: exir_ops.edge.aten.add.Tensor,
exir_ops.edge.aten.sub.Scalar: exir_ops.edge.aten.sub.Tensor,
exir_ops.edge.aten.mul.Scalar: exir_ops.edge.aten.mul.Tensor,
Expand Down
9 changes: 7 additions & 2 deletions backends/transforms/replace_scalar_with_tensor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
# This source code is licensed under the BSD-style license found in the
# LICENSE file in the root directory of this source tree.

from typing import Dict, Optional
from typing import Dict, Optional, Union

import torch
from executorch.exir.dialects._ops import ops as exir_ops
Expand All @@ -32,7 +32,12 @@ class ReplaceScalarWithTensorArgPass(ExportPass):

def __init__(
self,
scalar_to_tensor_ops: Optional[Dict[EdgeOpOverload, EdgeOpOverload]] = None,
scalar_to_tensor_ops: Optional[
Dict[
Union[EdgeOpOverload, torch._ops.OpOverload],
Union[EdgeOpOverload, torch._ops.OpOverload],
]
] = None,
):
if scalar_to_tensor_ops is not None:
self.scalar_to_tensor_ops = scalar_to_tensor_ops
Expand Down
Loading