Skip to content

[Backend Tester] Add LSTM tests #13238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 12, 2025
Merged

[Backend Tester] Add LSTM tests #13238

merged 2 commits into from
Aug 12, 2025

Conversation

GregoryComer
Copy link
Member

@GregoryComer GregoryComer commented Aug 8, 2025

Add tests for the LSTM module. This is done in the context of #12898.

[ghstack-poisoned]
@GregoryComer GregoryComer requested a review from cccclai as a code owner August 8, 2025 21:38
@GregoryComer
Copy link
Member Author

GregoryComer commented Aug 8, 2025

Copy link

pytorch-bot bot commented Aug 8, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13238

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 32881da with merge base 9c73b5d (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 8, 2025
@GregoryComer GregoryComer added the release notes: none Do not include this in the release notes label Aug 8, 2025
[ghstack-poisoned]
@@ -0,0 +1,208 @@
# Copyright (c) Meta Platforms, Inc. and affiliates.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if its an operator :P

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this is true. The operator tests could also be considered nn.Module + torch API surface tests. Open to ideas. Some backends, like Core ML (I believe), consume LSTM as a whole module, so I wanted to test it atomically.

@GregoryComer GregoryComer merged commit f556b96 into main Aug 12, 2025
101 of 102 checks passed
@GregoryComer GregoryComer deleted the gh/GregoryComer/105/head branch August 12, 2025 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: none Do not include this in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants