Skip to content

Removed some Silero models #284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 10, 2022
Merged

Conversation

NicolasHug
Copy link
Member

From #283 (comment)

In any case: snakers4_silero-vad_language.py and python_code/snakers4_silero-vad_number.py can be deprecated, because no one uses them and we decided to deprecate them.

CC @snakers4

Copy link
Contributor

@vmoens vmoens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

they'll be missed but otherwise lgtm

@snakers4
Copy link
Contributor

they'll be missed but otherwise lgtm

People seemed to have reacted to VAD much better
In a year almost no one asked us about these models =(
So we just focused on the main VAD

@netlify
Copy link

netlify bot commented May 10, 2022

Deploy Preview for pytorch-hub-preview ready!

Name Link
🔨 Latest commit a03cb21
🔍 Latest deploy log https://app.netlify.com/sites/pytorch-hub-preview/deploys/627a7e96db47ff000865ef2e
😎 Deploy Preview https://deploy-preview-284--pytorch-hub-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@NicolasHug NicolasHug merged commit ecc2afa into pytorch:master May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants