Skip to content

[Feature] Add deterministic_sample to masked categorical #2708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jan 26, 2025
Merged

[Feature] Add deterministic_sample to masked categorical #2708

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
6ef147e
Update
vmoens Jan 21, 2025
d21b527
Update
vmoens Jan 21, 2025
b77bec1
Update
vmoens Jan 21, 2025
08360ac
Update
vmoens Jan 25, 2025
8a9a6c0
Update
vmoens Jan 26, 2025
b627b9a
Update
vmoens Jan 26, 2025
19d45a8
Update
vmoens Jan 26, 2025
848c251
Update
vmoens Jan 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions torchrl/modules/distributions/discrete.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -319,6 +319,10 @@ def _mask_logits(
logits.masked_fill_(padding_mask, neg_inf)
return logits

@property
def deterministic_sample(self):
return self.mode


class MaskedOneHotCategorical(MaskedCategorical):
"""MaskedCategorical distribution.
Expand Down
Loading