Use Index Select instead of permute operation reduction in remote ro compute time #3097
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…compute time
Summary:
Did some offline benchmarking and found using index select is significantly faster than existing fbgemm.permute_embeddings when running KTRegroupAsDict for Ads model remote Ro. As a result pushing this up so we can speed up the Remote RO portion of computation.
KFS Sweeping runs show 10.5% improvement to QPS compared to without
details on analysis: N7315663
{F1979051531}
{F1979207570}
{F1979207218} {F1979207220}
Differential Revision: D76047913
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D76047913 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Did some offline benchmarking and found using index select is significantly faster than existing fbgemm.permute_embeddings when running KTRegroupAsDict for Ads model remote Ro. As a result pushing this up so we can speed up the Remote RO portion of computation.
KFS Sweeping runs show 10.5% improvement to QPS compared to without
details on analysis: N7315663
{F1979051531}
{F1979207570}
{F1979207218} {F1979207220}
Differential Revision: D76047913