OSS TorchRec MPZCH Modules #3162
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D77825114 |
|
This pull request was exported from Phabricator. Differential Revision: D77825114 |
lizhouyu
added a commit
to lizhouyu/torchrec
that referenced
this pull request
Jul 6, 2025
Summary: Pull Request resolved: pytorch#3162 ### Major changes - Copy the following files from `fb` to corresponding location in the `torchrec` repository - `fb/distributed/hash_mc_embedding.py → torchrec/distributed/hash_mc_embedding.py` - `fb/modules/hash_mc_evictions.py → torchrec/modules/hash_mc_evictions.py` - `fb/modules/hash_mc_metrics.py → torchrec/modules/hash_mc_metrics.py` - `fb/modules/hash_mc_modules.py → torchrec/modules/hash_mc_modules.py` - `fb/modules/tests/test_hash_mc_evictions.py → torchrec/modules/tests/test_hash_mc_evictions.py` - `fb/modules/tests/test_hash_mc_modules.py → torchrec/modules/tests/test_hash_mc_modules.py` - Update `/modules/hash_mc_metrics.py` - Replace the tensorboard module with a local file logger in `hash_mc_metrics.py` module to avoid OSS CI test failures - The original tensorboard version is kept in the `torchrec/fb` folder. - Update the license declaration headers for the OSS files - Add `unittest.skipif` condition to `test_dynamically_switch_inference_training_mode` and `test_output_global_offset_tensor` to skip these tests when GPU is not available. - Update import packages in `torch/modules/tests/test_hash_mc_modules.py` and `torch/modules/tests/test_hash_mc_evictions.py` from `torch.fb.modules.hash_mc_*` to `torch.modules.hash_mc_*`. And update the BUCK file correspondingly from `/torchrec/fb/modules/hash_mc_*` to `torchrec/modules/hash_mc_*` ### Next step - Wait for `fbpkg` to pick up the Diff and update the existing dependencies on MPZCH modules from `torchrec/fb/module` to `torchrec/modules`. - Wait for all the dependencies being updated, then clean up the files in `torchrec/fb/module`. Differential Revision: D77825114
lizhouyu
force-pushed
the
export-D77825114
branch
from
7d411d5 to
35958ec
Compare
Summary: ### Major changes - Copy the following files from `fb` to corresponding location in the `torchrec` repository - `fb/distributed/hash_mc_embedding.py → torchrec/distributed/hash_mc_embedding.py` - `fb/modules/hash_mc_evictions.py → torchrec/modules/hash_mc_evictions.py` - `fb/modules/hash_mc_metrics.py → torchrec/modules/hash_mc_metrics.py` - `fb/modules/hash_mc_modules.py → torchrec/modules/hash_mc_modules.py` - `fb/modules/tests/test_hash_mc_evictions.py → torchrec/modules/tests/test_hash_mc_evictions.py` - `fb/modules/tests/test_hash_mc_modules.py → torchrec/modules/tests/test_hash_mc_modules.py` - Update `/modules/hash_mc_metrics.py` - Replace the tensorboard module with a local file logger in `hash_mc_metrics.py` module to avoid OSS CI test failures - The original tensorboard version is kept in the `torchrec/fb` folder. - Update the license declaration headers for the OSS files - Add `unittest.skipif` condition to `test_dynamically_switch_inference_training_mode` and `test_output_global_offset_tensor` to skip these tests when GPU is not available. - Update import packages in `torch/modules/tests/test_hash_mc_modules.py` and `torch/modules/tests/test_hash_mc_evictions.py` from `torch.fb.modules.hash_mc_*` to `torch.modules.hash_mc_*`. And update the BUCK file correspondingly from `/torchrec/fb/modules/hash_mc_*` to `torchrec/modules/hash_mc_*` ### Next step - Wait for `fbpkg` to pick up the Diff and update the existing dependencies on MPZCH modules from `torchrec/fb/module` to `torchrec/modules`. - Wait for all the dependencies being updated, then clean up the files in `torchrec/fb/module`. Differential Revision: D77825114
lizhouyu
force-pushed
the
export-D77825114
branch
from
35958ec to
0479d82
Compare
|
This pull request was exported from Phabricator. Differential Revision: D77825114 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Major changes
fbto corresponding location in thetorchrecrepositoryfb/distributed/hash_mc_embedding.py → torchrec/distributed/hash_mc_embedding.pyfb/modules/hash_mc_evictions.py → torchrec/modules/hash_mc_evictions.pyfb/modules/hash_mc_metrics.py → torchrec/modules/hash_mc_metrics.pyfb/modules/hash_mc_modules.py → torchrec/modules/hash_mc_modules.pyfb/modules/tests/test_hash_mc_evictions.py → torchrec/modules/tests/test_hash_mc_evictions.pyfb/modules/tests/test_hash_mc_modules.py → torchrec/modules/tests/test_hash_mc_modules.py/modules/hash_mc_metrics.pyhash_mc_metrics.pymodule to avoid OSS CI test failurestorchrec/fbfolder.unittest.skipifcondition totest_dynamically_switch_inference_training_modeandtest_output_global_offset_tensorto skip these tests when GPU is not available.torch/modules/tests/test_hash_mc_modules.pyandtorch/modules/tests/test_hash_mc_evictions.pyfromtorch.fb.modules.hash_mc_*totorch.modules.hash_mc_*. And update the BUCK file correspondingly from/torchrec/fb/modules/hash_mc_*totorchrec/modules/hash_mc_*Next step
fbpkgto pick up the Diff and update the existing dependencies on MPZCH modules fromtorchrec/fb/moduletotorchrec/modules.torchrec/fb/module.Differential Revision: D77825114