Skip to content

Add tensorboard to display training and evaluation metrics #3163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

lizhouyu
Copy link
Contributor

@lizhouyu lizhouyu commented Jul 6, 2025

Differential Revision: D77841795

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 6, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D77841795

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D77841795

lizhouyu added a commit to lizhouyu/torchrec that referenced this pull request Jul 8, 2025
… implementation to support DLRMv2 (pytorch#3163)

Summary:
Pull Request resolved: pytorch#3163

### Major changes
- Add tensorboard to the benchmark testbed, specifically in `benchmark_zch.py`.
- Count the number of unique values received by each rank in each epoch by revising `benchmark_zch_utils.py`.
- Revise `data/non_zch_remapper.py` to not depend on `batch.to_dict()` method, instead it fetch dataclass `batch`'s attribute with the built-in `vars()` method.
-  Revise DLRMv2 model EBC config initialization to make the table name identical with the feature name.

Rollback Plan:

Differential Revision: D77841795
@lizhouyu lizhouyu force-pushed the export-D77841795 branch from c96a893 to f120f53 Compare July 8, 2025 00:10
lizhouyu added 2 commits July 8, 2025 11:33
Summary: Pull Request resolved: pytorch#3127

Differential Revision: D77033290
… implementation to support DLRMv2 (pytorch#3163)

Summary:
Pull Request resolved: pytorch#3163

### Major changes
- Add tensorboard to the benchmark testbed, specifically in `benchmark_zch.py`.
- Count the number of unique values received by each rank in each epoch by revising `benchmark_zch_utils.py`.
- Revise `data/non_zch_remapper.py` to not depend on `batch.to_dict()` method, instead it fetch dataclass `batch`'s attribute with the built-in `vars()` method.
-  Revise DLRMv2 model EBC config initialization to make the table name identical with the feature name.
- Revise DLRMv2 configuration yaml file to set table size for each feature.
- Revise the default value for "num_embeddings" parameter in  `arguments.py` to None.

Rollback Plan:

Differential Revision: D77841795
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D77841795

@lizhouyu lizhouyu force-pushed the export-D77841795 branch from f120f53 to 20ce4f0 Compare July 9, 2025 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants