add support of masking olci l1b products by using quality flags #2687
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main)
succeeded
Jul 26, 2024 in 36s
CodeScene PR Check
✅ Code Health Quality Gates: OK
Change in average Code Health of affected files: -0.14 (9.26 -> 9.11)
- Declining Code Health: 1 findings(s) 🚩
- Improving Code Health: 1 findings(s) ✅
Details
🚩 Declining Code Health (highest to lowest):
- Code Duplication test_olci_nc.py
✅ Improving Code Health:
- Code Duplication test_olci_nc.py
Annotations
Check notice on line 191 in satpy/readers/olci_nc.py
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
ℹ Getting worse: Excess Number of Function Arguments
NCOLCI1B.__init__ increases from 5 to 6 arguments, threshold = 4. This function has too many arguments, indicating a lack of encapsulation. Avoid adding more arguments.
Check warning on line 97 in satpy/tests/reader_tests/test_olci_nc.py
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ Getting worse: Code Duplication
introduced similar code in: TestL2BitFlags.test_bitflags,TestL2BitFlags.test_bitflags_with_custom_flag_list,TestL2BitFlags.test_bitflags_with_dataarray_without_flags,TestOLCIReader.test_get_l1b_customized_mask and 3 more functions. Avoid duplicated, aka copy-pasted, code inside the module. More duplication lowers the code health.
Check notice on line 1 in satpy/tests/reader_tests/test_olci_nc.py
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ Getting better: Code Duplication
reduced similar code in: TestBitFlags.test_bitflags,TestBitFlags.test_bitflags_with_custom_flag_list,TestBitFlags.test_bitflags_with_dataarray_without_flags,TestOLCIReader.test_get_mask and 1 more functions. Avoid duplicated, aka copy-pasted, code inside the module. More duplication lowers the code health.
Loading