Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MWR Polarisation #3046

Merged
merged 1 commit into from
Feb 4, 2025
Merged

Conversation

timhewison
Copy link
Contributor

Replacing PR # 3045

I noticed the readers for MWR on AWS (Arctic Weather Satellite) - L1B and L1C and EPS-Sterna (L1B) had the polarisation of several channels and bandwidth of 1 channel inaccurately described in the yaml files (it should be QV for all channels).

Changed all channels to polarisation: QV (some were listed as QH)
Changed channel 10 bandwidth to 2800 (was 2700)
values now match those given in OSCAR: https://space.oscar.wmo.int/instruments/view/mwr_aws, https://space.oscar.wmo.int/instruments/view/mwr_sterna
I have attempted this with much helpful support on the Satpy Stack channel: https://pytroll.slack.com/archives/C0LNH7LMB/p1738314449874509

I have not tested this, but the changes are trivial
This is my second PR - further feedback is welcome!

@coveralls
Copy link

Pull Request Test Coverage Report for Build 13077084708

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 96.222%

Totals Coverage Status
Change from base Build 12905542942: 0.0%
Covered Lines: 53758
Relevant Lines: 55869

💛 - Coveralls

@adybbroe adybbroe self-assigned this Feb 2, 2025
Copy link
Contributor

@adybbroe adybbroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for spotting and fixing this! Looks good.

@djhoese djhoese merged commit d8c4382 into pytroll:main Feb 4, 2025
30 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants