Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Coral prop/outline and fix Delete Object #87

Closed
wants to merge 6 commits into from
Closed

Add Coral prop/outline and fix Delete Object #87

wants to merge 6 commits into from

Conversation

Botman64
Copy link

was impossible to find the coral this is a major improvement and it was failing to take the prop off your back. Added coral props and drew an outline on them when within distance. Put distance check loop in a circle zone where the blip spawns so the loop doesnt fire until you are within that zone.

Describe Pull request
First, make sure you've read and are following the contribution guidelines and style guide and your code reflects that.
Write up a clear and concise description of what your pull request adds or fixes and if it's an added feature explain why you think it should be included in the core.

If your PR is to fix an issue mention that issue here

Questions (please complete the following information):

  • Have you personally loaded this code into an updated qbcore project and checked all it's functionality? [yes] (Be honest)
  • Does your code fit the style guidelines? [yes]
  • Does your PR fit the contribution guidelines? [yes]

was impossible to find the coral this is a major improvement and it was failing to take the prop off your back. Added coral props and drew an outline on them when within distance. Put distance check loop in a circle zone where the blip spawns so the loop doesnt fire until you are within that zone.
@nzkfc
Copy link

nzkfc commented Jan 1, 2023

Seems to work, bug the z axis of the coral is a bit borked:
https://i.imgur.com/pNVLWKQ.jpeg

also the NPC to buy coral doesn't seem to spawn?
ALso this error?
https://i.imgur.com/LIPem4z.png

@Botman64
Copy link
Author

Botman64 commented Jan 1, 2023

most recent update fixes the ped was kind of difficult to get the props on the ground 100 percent of the time with them being in the water

@nzkfc
Copy link

nzkfc commented Jan 1, 2023 via email

@Botman64
Copy link
Author

Botman64 commented Jan 1, 2023

Cant use the native for place on ground instead? Like it does to spawned cars in qb-vehicles hop?

On Mon, 2 Jan 2023, 12:00 am KamuiKody, @.> wrote: most recent update fixes the ped was kind of difficult to get the props on the ground 100 percent of the time with them being in the water — Reply to this email directly, view it on GitHub <#87 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABGHUHLFGRT4WWI4H4LUFMTWQFPV5ANCNFSM6AAAAAATNIQYMY . You are receiving this because you commented.Message ID: @.>

line 122 client. i did use it the water makes it not operate correctly everywhere i think

@Botman64 Botman64 closed this by deleting the head repository Jan 2, 2023
@Botman64 Botman64 reopened this Jan 4, 2023
@Z3rio Z3rio closed this Jan 4, 2023
@Z3rio Z3rio reopened this Jan 4, 2023
@Z3rio
Copy link
Contributor

Z3rio commented Jan 4, 2023

Sorry, my fault for closing it. Thought you removed your branch.

@Botman64 Botman64 closed this Jan 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants