Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Coral prop/outline and fix Delete Object #88

Closed

Conversation

r0adra93
Copy link

@r0adra93 r0adra93 commented Jan 4, 2023

Describe Pull request
First, make sure you've read and are following the contribution guidelines and style guide and your code reflects that.
Write up a clear and concise description of what your pull request adds or fixes and if it's an added feature explain why you think it should be included in the core.

If your PR is to fix an issue mention that issue here

Questions (please complete the following information):

  • Have you personally loaded this code into an updated qbcore project and checked all it's functionality? [yes
  • Does your code fit the style guidelines? yes
  • Does your PR fit the contribution guidelines? [yes

Kodi's Code:

was impossible to find the coral this is a major improvement and it was failing to take the prop off your back. Added coral props and drew an outline on them when within distance. Put distance check loop in a circle zone where the blip spawns so the loop doesnt fire until you are within that zone.

place on ground and freeze entity

add Entity ids to table
added missing polyzone data and upped the version
Copy link

@Botman64 Botman64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrote this for my own server and when i cleaned up my github i cleaned up too much this works well! Ready to ship

@nzkfc
Copy link

nzkfc commented Jan 13, 2023

Perfect this works! Tested it on 8 of our diving locations and is great.

@nzkfc
Copy link

nzkfc commented Jan 21, 2023

    Coral[k] = CreateObject(CoralProp, v.coords.x, v.coords.y, v.coords.z+**0.2**, false, false, false)
    
    Changing this to 0.2 seems to put the coral onto the floor for me everywhere no matter the slope etc.

image

https://i.imgur.com/3RTfY29.png

Copy link
Contributor

@S33G S33G left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@r0adra93 r0adra93 closed this Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants