Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sell reward, rework modifier #92

Merged
merged 1 commit into from
Jan 26, 2023
Merged

Fix sell reward, rework modifier #92

merged 1 commit into from
Jan 26, 2023

Conversation

AkinoKitsu
Copy link
Contributor

As noted in issue #89 selling a large quantity of coral resulted in a $1 reward.

This commit fixes the cash payout, and reworks the old modifier into a bonus system.

Prior to these changes, the more coral you sold, the less money would be rewarded.
This changes it to give a bonus percentage that gets higher when selling more coral, giving reward for risking having more illegal items in your pockets.

Questions (please complete the following information):

  • Have you personally loaded this code into an updated qbcore project and checked all it's functionality?
  • Does your code fit the style guidelines?
  • Does your PR fit the contribution guidelines?

As noted in issue #89 selling a large quantity of coral resulted in a $1 reward.

This commit fixes the cash payout, and reworks the old modifier into a bonus system.
Prior to these changes, the more coral you sold, the less money would be rewarded.
This changes it to give a bonus percentage that gets higher when selling more coral, giving reward for risking having more illegal items in your pockets.
@nzkfc
Copy link

nzkfc commented Jan 21, 2023

THHHHAANNKKK YOUUUUUU! Works perfect!

Copy link

@r0adra93 r0adra93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@S33G
Copy link
Contributor

S33G commented Jan 26, 2023

LGTM

@S33G S33G merged commit 05bc92a into qbcore-framework:main Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants