fix: prevent reload if weapon switched to incorrect ammo #199
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe Pull request
This PR checks the ammo type on the progressbar completion callback, without this you are able to switch weapon during the progress bar which will result in the metadata of the incorrect weapon and item being set and increasing the ammo. This is abusable by beginning to reload a pistol with pistol ammo and switching to an assault rifle as the assault rifle will then gain ammo when pulling the weapon back out.
This PR fixes the issue qbcore-framework/qb-inventory#574
Questions (please complete the following information):