Skip to content

Implement SetSubmatrix Trait for all Matrices #500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: dev
Choose a base branch
from

Conversation

Marvin-Beckmann
Copy link
Member

@Marvin-Beckmann Marvin-Beckmann commented Apr 14, 2025

Description

This PR implements...

  • the set submatrix trait for all matrices (test + documentation still missing)
  • uses generalized generic implemenetations for set_row and set_column to increase maintainability
  • optimizes internal implementation by using unchecked setter

Testing

  • I added basic working examples (possibly in doc-comment)
  • I added tests for large (pointer representation) values
  • I triggered all possible errors in my test in every possible way
  • I included tests for all reasonable edge cases

Checklist:

  • I have performed a self-review of my own code
    • The code provides good readability and maintainability s.t. it fulfills best practices like talking code, modularity, ...
      • The chosen implementation is not more complex than it has to be
    • My code should work as intended and no side effects occur (e.g. memory leaks)
    • The doc comments fit our style guide
    • I have credited related sources if needed

@Marvin-Beckmann Marvin-Beckmann added the enhancement📈 New feature label Apr 14, 2025
@Marvin-Beckmann Marvin-Beckmann self-assigned this Apr 14, 2025
@Marvin-Beckmann Marvin-Beckmann force-pushed the rework_base_error_handling branch from a201050 to 9481f3c Compare April 16, 2025 08:54
@Marvin-Beckmann Marvin-Beckmann force-pushed the set_submatrix branch 2 times, most recently from 7e81e67 to 6c4d3e6 Compare April 16, 2025 15:33
Base automatically changed from rework_base_error_handling to dev April 16, 2025 15:34
@Marvin-Beckmann Marvin-Beckmann marked this pull request as ready for review April 16, 2025 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement📈 New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant