Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor readout mitigation matrix routine #1045

Merged
merged 9 commits into from
Nov 25, 2024

Conversation

Edoardo-Pedicillo
Copy link
Contributor

@Edoardo-Pedicillo Edoardo-Pedicillo commented Nov 20, 2024

  • Remove pulse option
  • use proper data attribute
  • simplify post-processing
  • fix bug (matrix flipping)
  • (small fixes in mermin)
  • propagate in CHSH

http://login.qrccluster.com:9000/ots5pm92QcWJRS5-lJx4Fg==/

Checklist:

  • Reviewers confirm new code works as expected.
  • Tests are passing.
  • Coverage does not decrease.
  • Documentation is updated.
  • Compatibility with Qibo modules (Please edit this section if the current pull request is not compatible with the following branches).
    • Qibo: master
    • Qibolab: 0.1
    • Qibolab_platforms_qrc: 0.1

@alecandido alecandido changed the title Readout readout mitigation matrix routine Readout mitigation matrix routine Nov 20, 2024
@Edoardo-Pedicillo Edoardo-Pedicillo changed the title Readout mitigation matrix routine Refactor readout mitigation matrix routine Nov 20, 2024
@Edoardo-Pedicillo Edoardo-Pedicillo mentioned this pull request Nov 20, 2024
8 tasks
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.31%. Comparing base (c8b54f2) to head (d7f30da).
Report is 10 commits behind head on mermin_refactor.

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##           mermin_refactor    #1045      +/-   ##
===================================================
- Coverage            97.34%   97.31%   -0.03%     
===================================================
  Files                  124      124              
  Lines                 9914     9888      -26     
===================================================
- Hits                  9651     9623      -28     
- Misses                 263      265       +2     
Flag Coverage Δ
unittests 97.31% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/qibocal/protocols/readout_mitigation_matrix.py 97.50% <100.00%> (-2.50%) ⬇️
...l/protocols/two_qubit_interaction/chsh/circuits.py 100.00% <100.00%> (ø)
...l/protocols/two_qubit_interaction/chsh/protocol.py 97.66% <100.00%> (ø)
...protocols/two_qubit_interaction/mermin/protocol.py 100.00% <100.00%> (ø)
---- 🚨 Try these New Features:

@Edoardo-Pedicillo Edoardo-Pedicillo marked this pull request as ready for review November 22, 2024 08:22
@Edoardo-Pedicillo Edoardo-Pedicillo merged commit 5204ba3 into mermin_refactor Nov 25, 2024
21 checks passed
@Edoardo-Pedicillo Edoardo-Pedicillo deleted the readout_mitigation branch November 25, 2024 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants