-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CHSH pulses routine to 0.2 #1049
base: 0.2
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 0.2 #1049 +/- ##
==========================================
- Coverage 97.02% 96.91% -0.12%
==========================================
Files 98 102 +4
Lines 7893 8091 +198
==========================================
+ Hits 7658 7841 +183
- Misses 235 250 +15
Flags with carried forward coverage won't be shown. Click here to find out more.
|
try: | ||
return chsh / nshots | ||
except ZeroDivisionError: | ||
log.warning("Zero number of shots, returning zero.") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Drop the warning, just noise :P
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If 0 is not a consistent limit value, consider returning nan
. If it is consistent, no need to do anything :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed the warning in 549b504, even though this code was just copy pasted from the main
branch and not originally authored by me. Regarding 0
, I am not sure if it is consistent, however it seems to me that the except
branch is never going to be executed in practice, as I don't see why someone would launch this routine (or anything on hardware) with nshots == 0
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could even consider nshots == 0
, and just leave the original exception.
Marking this as ready as I managed to get consistent results with 0.1 for B1-B3 pair: 0.1: http://login.qrccluster.com:9000/Pk4B8i3mRoaHOIWMDX7AWg== Note that I used qiboteam/qibolab#1116 for this. |
Still need to confirm it works properly on hardware.