Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding CPMG protocol #1057
base: 0.2
Are you sure you want to change the base?
Adding CPMG protocol #1057
Changes from 2 commits
0b625f3
db00d75
6fcf9d6
1a8f9f7
61c91af
fb165fc
0060809
27950de
db90428
526993b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This behaviour depends on the kind of noise.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure about this. Generally by increasing the number of pi pulses according to here I believe that we should be able to mitigate noises of the type 1/f. Then I don't know whether we could have other noises which are not 1/f but I don't know if we can detect them through a CPMG sequence.
Did you have something else in mind?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could have a white noise but I think the conclusions are the same. I just suggest to add what you have written in this comment in the docs.
By changing the number of pulses increase the sensitivity to higher frequencies, so I would say yes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we delete this routine to reduce code duplication ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, the spin-echo protocol doesn't implement the CPMG sequence but the CP sequence, which is slightly different.
qibocal/src/qibocal/protocols/coherence/spin_echo.py
Line 44 in db00d75
But yes, generally I agree the two protocols are exactly the same apart from the sequence type.