-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cryoscope related protocols #974
Draft
andrea-pasquale
wants to merge
21
commits into
0.2
Choose a base branch
from
test_cryoscope
base: 0.2
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 0.2 #974 +/- ##
==========================================
+ Coverage 97.02% 97.11% +0.09%
==========================================
Files 98 101 +3
Lines 7893 8178 +285
==========================================
+ Hits 7658 7942 +284
- Misses 235 236 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
andrea-pasquale
force-pushed
the
test_cryoscope
branch
from
November 18, 2024 14:43
434755a
to
5544539
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is adding 3 protocols which are related to the cryoscope.
Although the plot is significantly different from #1041, the reconstructed waveform seems to more or less agree with the expected one.
(3) requires (2) to reconstruct the waveform. Currently those parameters are hardcoded in the fitting. With @Edoardo-Pedicillo we agreed on moving them in the calibration object.
Checklist:
master
main
main