-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IMP: ANCOM -> ANCOM-BC tutorial updates #569
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really good to me @lizgehret. You do an incredible job of explaining ancom-bc
Co-authored-by: Chloe Herman <[email protected]>
Co-authored-by: Chloe Herman <[email protected]>
Co-authored-by: Chloe Herman <[email protected]>
@lizgehret, this looks great! I made a few little edits in the most recent commit.
Also, in the multiple interfaces moving pictures tutorial, the filtering command is rendering strangely: If you're good with my edits, this is good to merge once we get that rendering issue sorted out. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just see my comment above about the filtering command rendering strangely. I don't need to review this again before merge. Thanks @lizgehret!
Thanks @gregcaporaso! Oh yeah, that does look weird - I'll render locally and see what's going on there! |
Okay, so for posterity - this has been fixed, and now looks reasonable when rendered locally: Once this passes on CI, I'll go ahead and merge. Thanks for the review @gregcaporaso! |
Thanks @lizgehret! |
Replaces ancom with ancombc in PD Mice and Moving Pictures tutorials.