feat: add configurable mention triggers support #334
Merged
+371
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
CarlJi
commented
Aug 26, 2025
CarlJi
commented
- Add mention configuration to config structure with triggers array and default trigger
- Implement enhanced mention parsing with regex-based exact matching
- Support multiple mention triggers (@ai, @code-assistant, @qiniu-ci)
- Add comprehensive test coverage for mention parsing functionality
- Maintain backward compatibility with existing @qiniu-ci trigger
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #334 +/- ##
=======================================
Coverage ? 12.86%
=======================================
Files ? 52
Lines ? 11052
Branches ? 0
=======================================
Hits ? 1422
Misses ? 9482
Partials ? 148
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
CarlJi
commented
Aug 27, 2025
config.example.yaml
Outdated
| # Supports multiple triggers for different use cases | ||
| triggers: | ||
| - "@qiniu-ci" # Default company AI assistant | ||
| - "@ai" # Short alias |
|
/review |
|
🤖 代码审查结果 I have completed my comprehensive code review of PR #334. The review covers all aspects requested:
The PR implements configurable mention triggers with excellent test coverage (276 lines), maintains backward compatibility, and uses robust regex-based matching. I recommend APPROVAL with the noted minor improvements as optional enhancements for future iterations. |
CarlJi
commented
Aug 27, 2025
pkg/models/events.go
Outdated
Comment on lines
293
to
297
| // 使用正则表达式进行精确匹配，参考claude-code-action的匹配规则 | ||
| // 匹配规则：(^|\s)trigger([\s.,!?;:]|$) | ||
| // - (^|\s): 匹配字符串开始或空白字符 | ||
| // - trigger: 精确匹配触发短语 | ||
| // - ([\s.,!?;:]|$): 匹配空白字符、标点符号或字符串结束 |
- Add mention configuration to config structure with triggers array and default trigger - Implement enhanced mention parsing with regex-based exact matching - Support multiple mention triggers (@ai, @code-assistant, @qiniu-ci) - Add comprehensive test coverage for mention parsing functionality - Maintain backward compatibility with existing @qiniu-ci trigger
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.