Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: add information about unfocused windows to TuioTouch README #104

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

3n3l
Copy link

@3n3l 3n3l commented Sep 26, 2024

I had some issues getting the TuioTouch plugin to work, as my sending application would take focus over my receiving QtQuick application. I try to prevent this issue in the future for other users, by adding a small hint to the README of the plugin.

langlor-autodesk pushed a commit to autodesk-forks/qtbase that referenced this pull request Nov 11, 2024
…t#104)

* rhi: d3d11: Flush() when destroying a swapchain

Task-number: QTBUG-120276
Pick-to: 6.7 6.6 6.5
Change-Id: Iaf79c4dcf60d9a52bd562fd94976402cf570147d
Reviewed-by: Tor Arne Vestbø <[email protected]>
(cherry picked from commit cff5a49)

* widgets: Invalidate RHI swapchain when window moves to new top level

When a QWidget with an associated RHI swapchain (via its QWindow) is
moved to a different top level window, that top level window has its
own backing store, and QBackingStoreRhiSupport, which doesn't know
anything about the fact that the window already has an associated
swap chain in the original top level window's QBackingStoreRhiSupport.

As having multiple swap chains for the same window is not supported
on all RHI backends (Vulkan and DX in particular), we need to throw
away the swap chain when detecting that the window is moved to a new
top level.

We do this by hooking into the existing WindowAboutToChangeInternal
event delivery to renderToTexture children, which now delivers the
event both to renderToTexture QWidget children as well as QWindows
in the hierarchy. The condition of when to deliver the event has
been updated to reflect whether the top level uses RHI for flushing,
instead of only including renderToTexture children, as the former
also includes setting QT_WIDGETS_RHI=1 explicitly.

The event is then caught by QBackingStoreRhiSupportWindowWatcher,
and handled the same way as for SurfaceAboutToBeDestroyed.

Renaming qSendWindowChangeToTextureChildrenRecursively would make
sense at this point, but to make cherry-picks easier we keep the
current name for now.

Fixes: QTBUG-120276
Pick-to: 6.7 6.5
Change-Id: Ic4c60e89be985f12a84e9f893c299e602b70851a
Reviewed-by: Qt CI Bot <[email protected]>
Reviewed-by: Laszlo Agocs <[email protected]>
(cherry picked from commit 1bd7554)

rename sendWindowChangeToTextureChildrenRecursively

Change-Id: I457f50b68d5813e3ef09c31749dc3db8d0dc6822

---------

Co-authored-by: Laszlo Agocs <[email protected]>
Co-authored-by: Tor Arne Vestbø <[email protected]>
Copy link

cla-assistant bot commented Nov 15, 2024

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant