Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed https support #14

Merged
merged 1 commit into from
Nov 27, 2024
Merged

Fixed https support #14

merged 1 commit into from
Nov 27, 2024

Conversation

falling-springs
Copy link
Contributor

Fixed support for https by providing https scheme alongside domain when creating client.

@lmangani lmangani requested a review from ahuarte47 November 26, 2024 13:10
@lmangani
Copy link
Collaborator

Thanks for the contribution and welcome to the group @falling-springs
LGTM @ahuarte47 could you co-review approve this PR?

Copy link
Collaborator

@ahuarte47 ahuarte47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @falling-springs !

@falling-springs
Copy link
Contributor Author

@lmangani Great, glad to help! FYI, I think the test failure during CI may be an intermittent issue with the httpbin site used in the SQL tests. Looks like the server returned a 502: Bad Gateway error, which can't be parsed as JSON and so creates the error we see in the CI logs. It may be worth revising this test to use a different domain if this is a regular issue?

For now I think if you re-run that step it will likely pass

@lmangani lmangani merged commit 4790bc7 into quackscience:main Nov 27, 2024
35 of 36 checks passed
@ahuarte47
Copy link
Collaborator

ahuarte47 commented Nov 30, 2024

Hi, sorry for this late message, this MR was great and it is working, but why not including always the scheme part in the client_url?

May I suggest a super simple change maybe in other new PR?

image

@lmangani
Copy link
Collaborator

lmangani commented Dec 4, 2024

Hi, sorry for this late message, this MR was great and it is working, but why not including always the scheme part in the client_url?

May I suggest a super simple change maybe in other new PR?

Please go ahead and I'll create an updated release 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants