Skip to content

Commit

Permalink
Merge pull request #14 from quackscience/revert-10-feature/duck_flock
Browse files Browse the repository at this point in the history
Revert "Duck Flock for HTTP Server"
  • Loading branch information
lmangani authored Nov 15, 2024
2 parents a127955 + 4668a2e commit 6008ce1
Show file tree
Hide file tree
Showing 4 changed files with 2 additions and 84 deletions.
2 changes: 1 addition & 1 deletion CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ set(LOADABLE_EXTENSION_NAME ${TARGET_NAME}_loadable_extension)
project(${TARGET_NAME})
include_directories(src/include duckdb/third_party/httplib duckdb/parquet/include)

set(EXTENSION_SOURCES src/httpserver_extension.cpp src/duck_flock.cpp)
set(EXTENSION_SOURCES src/httpserver_extension.cpp)

if(MINGW)
set(OPENSSL_USE_STATIC_LIBS TRUE)
Expand Down
78 changes: 0 additions & 78 deletions src/duck_flock.cpp

This file was deleted.

4 changes: 1 addition & 3 deletions src/httpserver_extension.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -77,8 +77,6 @@ static HttpServerState global_state;
int64_t read_rows;
};



// Convert the query result to JSON format
static std::string ConvertResultToJSON(MaterializedQueryResult &result, ReqStats &req_stats) {
auto doc = yyjson_mut_doc_new(nullptr);
Expand Down Expand Up @@ -471,7 +469,7 @@ static void LoadInternal(DatabaseInstance &instance) {

ExtensionUtil::RegisterFunction(instance, httpserve_start);
ExtensionUtil::RegisterFunction(instance, httpserve_stop);
ExtensionUtil::RegisterFunction(instance, DuckFlockTableFunction());

// Register the cleanup function to be called at exit
std::atexit(HttpServerCleanup);
}
Expand Down
2 changes: 0 additions & 2 deletions src/include/httpserver_extension.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,4 @@ struct HttpServerState;
void HttpServerStart(DatabaseInstance& db, string_t host, int32_t port);
void HttpServerStop();

TableFunction DuckFlockTableFunction();

} // namespace duckdb

0 comments on commit 6008ce1

Please sign in to comment.