Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

draft: Strip equal sign in generate_dagster_name() and add possibillity of custom dagster_name #45

Closed
wants to merge 5 commits into from

Conversation

ReneTC
Copy link
Contributor

@ReneTC ReneTC commented Oct 10, 2023

Adding .replace("=", "_") the the generate_dagster_name function. As Meltano prod runs are called with:

meltano --environment=prod run your:command

Draft: As I was not able to test this

@JulesHuisman
Copy link
Contributor

To test it you can either create a pytest test.

Or you can use this project to test it: https://github.com/quantile-development/dagster-meltano/tree/master/meltano_project

@JulesHuisman
Copy link
Contributor

And if you could bump the version here: https://github.com/quantile-development/dagster-meltano/blob/master/pyproject.toml

That way it's easier to publish for me :)

@ReneTC
Copy link
Contributor Author

ReneTC commented Oct 10, 2023

To test it you can either create a pytest test.

Or you can use this project to test it: https://github.com/quantile-development/dagster-meltano/tree/master/meltano_project

As in independent function it works as expected. I wanted originally to test it with dagster.

And if you could bump the version here: https://github.com/quantile-development/dagster-meltano/blob/mast/pyproject.toml
That way it's easier to publish for me :)

I bumped it back actually as I couldn't get my conflict to work. So the only changed file in this MR is dagster_meltano/utils.py

Added the posibility of a custom dagster op name. If not set, it will default to the command generated name
@ReneTC
Copy link
Contributor Author

ReneTC commented Oct 11, 2023

Added posibility of a custom dagster_name. It is just a suggestion, feel free to suggest changes or revert.

@ReneTC ReneTC changed the title draft: Strip equal sign in generate_dagster_name() draft: Strip equal sign in generate_dagster_name() and add possibillity of custom dagster_name Oct 11, 2023
@ReneTC
Copy link
Contributor Author

ReneTC commented Oct 13, 2023

Getting messy, I'll close this and only keep the string replace =

@ReneTC ReneTC closed this Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants