Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to define upstream deps to created Dagster asset #35

Merged
merged 2 commits into from
Sep 25, 2024
Merged

Add the ability to define upstream deps to created Dagster asset #35

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
beea9d4
Add the ability to define upstream deps to created Dagster asset
guusfrenken-wk Sep 19, 2024
5e3a587
Regenerate lockfile
guusfrenken-wk Sep 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions elx/extensions/dagster/assets.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
from typing import Generator, List
from typing import Generator, Iterable, List, Sequence
from elx import Runner
from dagster import (
AssetsDefinition,
Expand All @@ -7,14 +7,20 @@
Output,
multi_asset,
AssetOut,
SourceAsset,
AssetKey,
AssetDep,
get_dagster_logger,
)
from elx.extensions.dagster.utils import dagster_safe_name, generate_description

logger = get_dagster_logger()


def load_assets(runner: Runner) -> List[AssetsDefinition]:
def load_assets(
runner: Runner,
deps: Iterable[AssetKey | str | Sequence[str] | AssetsDefinition | SourceAsset | AssetDep] | None = None,
) -> List[AssetsDefinition]:
"""
Load the assets for a runner, each asset represents one tap target combination.

Expand Down Expand Up @@ -67,6 +73,7 @@ def run(context: OpExecutionContext) -> Generator[Output, None, None]:
return [
multi_asset(
name=f"run_{dagster_safe_name(runner.tap.executable)}_{dagster_safe_name(runner.target.executable)}",
deps=deps,
outs={
dagster_safe_name(stream.name): AssetOut(
is_required=False,
Expand Down
Loading
Loading