Delete or Update Editorial bot comments when violations are fixed #546
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayagmar
changed the title
ayagmar
force-pushed
the
feat/469
branch
2 times, most recently
from
90735c4 to
68f3b44
Compare
ayagmar
changed the title
ayagmar
force-pushed
the
feat/469
branch
2 times, most recently
from
ffa6562 to
7c73760
Compare
|
Hello @gsmet |
|
ping @gsmet |
|
Hey there, Thanks for the pull request, I will have a look :). |
gsmet
reviewed
May 21, 2025
There was a problem hiding this comment.
Thanks, it looks really good and I see you added tests which is great.
I added a few comments.
Also, could you please rebase and run a full build to get the imports sorted. I somehow forgot to set up the impsort-maven-plugin when I created the project.
Let me know if you have any questions and don't hesitate to push back if something in my comments seems off.
src/main/java/io/quarkus/bot/CheckPullRequestEditorialRules.java
Outdated
Show resolved
Hide resolved
src/main/java/io/quarkus/bot/violation/ViolationDetectorManager.java
Outdated
Show resolved
Hide resolved
|
Hello @gsmet Thanks for the review, I have made some changes and fixed the formatting, let me know what you think |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #469 Handle Edited events to modify or delete bot comments if violations are updated
I have tested this on my gh bot fork and everything works as expected
Comment edited when I fixed one violation :
Comment is removed when I fixed all violations
Thanks!