Add tests for redis dev services behaviour in devmode #47968
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
holly-cummins
force-pushed
the
redis-devmode-tests
branch
from
f8fd700 to
9f95e9f
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
holly-cummins
force-pushed
the
redis-devmode-tests
branch
from
d7fd46e to
20866b2
Compare
This comment has been minimized.
This comment has been minimized.
holly-cummins
force-pushed
the
redis-devmode-tests
branch
from
20866b2 to
6ddda62
Compare
This comment has been minimized.
This comment has been minimized.
holly-cummins
commented
May 21, 2025
| "Expected random port 6377, but got: " + Arrays.toString(container.getPorts())); | ||
|
|
||
| test.modifyResourceFile("application.properties", | ||
| s -> ContinuousTestingTestUtils.appProperties("quarkus.redis.devservices.port=6377")); |
There was a problem hiding this comment.
Suggest using the FIXED_PORT_PROPERTIES constant here.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Status for workflow
|
geoand
approved these changes
May 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #47610, I realised we didn't have much coverage of continuous testing and the redis dev services.
I've added tests to make sure that dev services work, and that containers are (a) updated or (b) reused when the app changes. I expected that disabling dev services would make the dev service go away, but that's not currently working, so I've disabled that test.