Remove regex from hot path in micrometer #48037
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @ebullient (micrometer) |
This comment has been minimized.
This comment has been minimized.
gsmet
requested changes
May 24, 2025
...micrometer/runtime/src/main/java/io/quarkus/micrometer/runtime/binder/RequestMetricInfo.java
Show resolved
Hide resolved
gsmet
reviewed
May 24, 2025
...micrometer/runtime/src/main/java/io/quarkus/micrometer/runtime/binder/RequestMetricInfo.java
Outdated
Show resolved
Hide resolved
|
Nice improvement! It's really cool we're trying to reduce the observability costs. |
brunobat
force-pushed
the
micrometer-optimizations-1
branch
from
f49d4b3 to
3515128
Compare
brunobat
force-pushed
the
micrometer-optimizations-1
branch
from
3515128 to
3b166b7
Compare
Status for workflow
|
geoand
approved these changes
May 26, 2025
gsmet
approved these changes
May 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the OTel performance work, which now includes Micrometer, some inefficiencies were detected on the hot path. This affects all requests and uses ~5% of the samples in the test run.