Skip to content

Continuous Integration #4646

Continuous Integration

Continuous Integration #4646

GitHub Actions / clippy succeeded Dec 10, 2024 in 0s

clippy

14 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 14
Note 0
Help 0

Versions

  • rustc 1.83.0 (90b35a623 2024-11-26)
  • cargo 1.83.0 (5ffbef321 2024-10-29)
  • clippy 0.1.83 (90b35a6 2024-11-26)

Annotations

Check warning on line 671 in src/hardware/setup.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

creating a mutable reference to mutable static is discouraged

warning: creating a mutable reference to mutable static is discouraged
   --> src/hardware/setup.rs:671:29
    |
671 |         let ring = unsafe { DES_RING.write(ethernet::DesRing::new()) };
    |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ mutable reference to mutable static
    |
    = note: for more information, see <https://doc.rust-lang.org/nightly/edition-guide/rust-2024/static-mut-references.html>
    = note: mutable references to mutable statics are dangerous; it's undefined behavior if any other pointer to the static is used or if any other reference is created for the static while the mutable reference lives

Check warning on line 378 in src/hardware/adc.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

creating a mutable reference to mutable static is discouraged

warning: creating a mutable reference to mutable static is discouraged
   --> src/hardware/adc.rs:378:25
    |
378 |                           ADC_BUF.write(Default::default())
    |                           ^^^^^^^ mutable reference to mutable static
...
446 | / adc_input!(
447 | |     Adc1Input, 1, Stream3, Stream4, Stream5, SPI3, Channel2, Tim2Ch2, Channel2,
448 | |     Tim3Ch2
449 | | );
    | |_- in this macro invocation
    |
    = note: for more information, see <https://doc.rust-lang.org/nightly/edition-guide/rust-2024/static-mut-references.html>
    = note: mutable references to mutable statics are dangerous; it's undefined behavior if any other pointer to the static is used or if any other reference is created for the static while the mutable reference lives
    = note: this warning originates in the macro `adc_input` (in Nightly builds, run with -Z macro-backtrace for more info)

Check warning on line 341 in src/hardware/adc.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

creating a mutable reference to mutable static is discouraged

warning: creating a mutable reference to mutable static is discouraged
   --> src/hardware/adc.rs:341:25
    |
341 |                           SPI_START.write([0x201])
    |                           ^^^^^^^^^ mutable reference to mutable static
...
446 | / adc_input!(
447 | |     Adc1Input, 1, Stream3, Stream4, Stream5, SPI3, Channel2, Tim2Ch2, Channel2,
448 | |     Tim3Ch2
449 | | );
    | |_- in this macro invocation
    |
    = note: for more information, see <https://doc.rust-lang.org/nightly/edition-guide/rust-2024/static-mut-references.html>
    = note: mutable references to mutable statics are dangerous; it's undefined behavior if any other pointer to the static is used or if any other reference is created for the static while the mutable reference lives
    = note: this warning originates in the macro `adc_input` (in Nightly builds, run with -Z macro-backtrace for more info)

Check warning on line 298 in src/hardware/adc.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

creating a mutable reference to mutable static is discouraged

warning: creating a mutable reference to mutable static is discouraged
   --> src/hardware/adc.rs:298:25
    |
298 |                           SPI_EOT_CLEAR.write([1 << 3])
    |                           ^^^^^^^^^^^^^ mutable reference to mutable static
...
446 | / adc_input!(
447 | |     Adc1Input, 1, Stream3, Stream4, Stream5, SPI3, Channel2, Tim2Ch2, Channel2,
448 | |     Tim3Ch2
449 | | );
    | |_- in this macro invocation
    |
    = note: for more information, see <https://doc.rust-lang.org/nightly/edition-guide/rust-2024/static-mut-references.html>
    = note: mutable references to mutable statics are dangerous; it's undefined behavior if any other pointer to the static is used or if any other reference is created for the static while the mutable reference lives
    = note: this warning originates in the macro `adc_input` (in Nightly builds, run with -Z macro-backtrace for more info)

Check warning on line 378 in src/hardware/adc.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

creating a mutable reference to mutable static is discouraged

warning: creating a mutable reference to mutable static is discouraged
   --> src/hardware/adc.rs:378:25
    |
378 |                           ADC_BUF.write(Default::default())
    |                           ^^^^^^^ mutable reference to mutable static
...
442 | / adc_input!(
443 | |     Adc0Input, 0, Stream0, Stream1, Stream2, SPI2, Channel1, Tim2Ch1, Channel1,
444 | |     Tim3Ch1
445 | | );
    | |_- in this macro invocation
    |
    = note: for more information, see <https://doc.rust-lang.org/nightly/edition-guide/rust-2024/static-mut-references.html>
    = note: mutable references to mutable statics are dangerous; it's undefined behavior if any other pointer to the static is used or if any other reference is created for the static while the mutable reference lives
    = note: this warning originates in the macro `adc_input` (in Nightly builds, run with -Z macro-backtrace for more info)

Check warning on line 341 in src/hardware/adc.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

creating a mutable reference to mutable static is discouraged

warning: creating a mutable reference to mutable static is discouraged
   --> src/hardware/adc.rs:341:25
    |
341 |                           SPI_START.write([0x201])
    |                           ^^^^^^^^^ mutable reference to mutable static
...
442 | / adc_input!(
443 | |     Adc0Input, 0, Stream0, Stream1, Stream2, SPI2, Channel1, Tim2Ch1, Channel1,
444 | |     Tim3Ch1
445 | | );
    | |_- in this macro invocation
    |
    = note: for more information, see <https://doc.rust-lang.org/nightly/edition-guide/rust-2024/static-mut-references.html>
    = note: mutable references to mutable statics are dangerous; it's undefined behavior if any other pointer to the static is used or if any other reference is created for the static while the mutable reference lives
    = note: this warning originates in the macro `adc_input` (in Nightly builds, run with -Z macro-backtrace for more info)

Check warning on line 298 in src/hardware/adc.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

creating a mutable reference to mutable static is discouraged

warning: creating a mutable reference to mutable static is discouraged
   --> src/hardware/adc.rs:298:25
    |
298 |                           SPI_EOT_CLEAR.write([1 << 3])
    |                           ^^^^^^^^^^^^^ mutable reference to mutable static
...
442 | / adc_input!(
443 | |     Adc0Input, 0, Stream0, Stream1, Stream2, SPI2, Channel1, Tim2Ch1, Channel1,
444 | |     Tim3Ch1
445 | | );
    | |_- in this macro invocation
    |
    = note: for more information, see <https://doc.rust-lang.org/nightly/edition-guide/rust-2024/static-mut-references.html>
    = note: mutable references to mutable statics are dangerous; it's undefined behavior if any other pointer to the static is used or if any other reference is created for the static while the mutable reference lives
    = note: `#[warn(static_mut_refs)]` on by default
    = note: this warning originates in the macro `adc_input` (in Nightly builds, run with -Z macro-backtrace for more info)

Check warning on line 34 in src/hardware/shared_adc.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the following explicit lifetimes could be elided: 'a

warning: the following explicit lifetimes could be elided: 'a
  --> src/hardware/shared_adc.rs:34:6
   |
34 | impl<'a, Adc, PIN> AdcChannel<'a, Adc, PIN>
   |      ^^                       ^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
   |
34 - impl<'a, Adc, PIN> AdcChannel<'a, Adc, PIN>
34 + impl<Adc, PIN> AdcChannel<'_, Adc, PIN>
   |

Check warning on line 138 in src/hardware/pounder/dds_output.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the following explicit lifetimes could be elided: 'a

warning: the following explicit lifetimes could be elided: 'a
   --> src/hardware/pounder/dds_output.rs:138:6
    |
138 | impl<'a> ProfileBuilder<'a> {
    |      ^^                 ^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
    = note: `#[warn(clippy::needless_lifetimes)]` on by default
help: elide the lifetimes
    |
138 - impl<'a> ProfileBuilder<'a> {
138 + impl ProfileBuilder<'_> {
    |

Check warning on line 594 in serial-settings/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the following explicit lifetimes could be elided: 'a

warning: the following explicit lifetimes could be elided: 'a
   --> serial-settings/src/lib.rs:594:6
    |
594 | impl<'a, P: Platform, const Y: usize> Write for Interface<'a, P, Y> {
    |      ^^                                                   ^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
    |
594 - impl<'a, P: Platform, const Y: usize> Write for Interface<'a, P, Y> {
594 + impl<P: Platform, const Y: usize> Write for Interface<'_, P, Y> {
    |

Check warning on line 590 in serial-settings/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the following explicit lifetimes could be elided: 'a

warning: the following explicit lifetimes could be elided: 'a
   --> serial-settings/src/lib.rs:590:6
    |
590 | impl<'a, P: Platform, const Y: usize> ErrorType for Interface<'a, P, Y> {
    |      ^^                                                       ^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
    |
590 - impl<'a, P: Platform, const Y: usize> ErrorType for Interface<'a, P, Y> {
590 + impl<P: Platform, const Y: usize> ErrorType for Interface<'_, P, Y> {
    |

Check warning on line 581 in serial-settings/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the following explicit lifetimes could be elided: 'a

warning: the following explicit lifetimes could be elided: 'a
   --> serial-settings/src/lib.rs:581:6
    |
581 | impl<'a, P: Platform, const Y: usize> core::fmt::Write for Interface<'a, P, Y> {
    |      ^^                                                              ^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
    = note: `#[warn(clippy::needless_lifetimes)]` on by default
help: elide the lifetimes
    |
581 - impl<'a, P: Platform, const Y: usize> core::fmt::Write for Interface<'a, P, Y> {
581 + impl<P: Platform, const Y: usize> core::fmt::Write for Interface<'_, P, Y> {
    |

Check warning on line 23 in encoded_pin/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the following explicit lifetimes could be elided: 'a

warning: the following explicit lifetimes could be elided: 'a
  --> encoded_pin/src/lib.rs:23:6
   |
23 | impl<'a, P: OutputPin, const N: usize> OutputPin for EncodedPin<'a, P, N> {
   |      ^^                                                         ^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
   |
23 - impl<'a, P: OutputPin, const N: usize> OutputPin for EncodedPin<'a, P, N> {
23 + impl<P: OutputPin, const N: usize> OutputPin for EncodedPin<'_, P, N> {
   |

Check warning on line 19 in encoded_pin/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the following explicit lifetimes could be elided: 'a

warning: the following explicit lifetimes could be elided: 'a
  --> encoded_pin/src/lib.rs:19:6
   |
19 | impl<'a, P: ErrorType, const N: usize> ErrorType for EncodedPin<'a, P, N> {
   |      ^^                                                         ^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
   = note: `#[warn(clippy::needless_lifetimes)]` on by default
help: elide the lifetimes
   |
19 - impl<'a, P: ErrorType, const N: usize> ErrorType for EncodedPin<'a, P, N> {
19 + impl<P: ErrorType, const N: usize> ErrorType for EncodedPin<'_, P, N> {
   |