Don't use '-' as a compltion trigger character (messes up crossref co…

…mpletions)
quarto-dev · Nov 11, 2022 · 5ed057c · 5ed057c
1 parent 5f68e4b
commit 5ed057c
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 8 deletions.
diff --git a/server/src/providers/completion/completion-attrs.ts b/server/src/providers/completion/completion-attrs.ts
@@ -13,7 +13,7 @@ export async function attrCompletions(context: EditorContext) {
   }
 
   // validate trigger
-  if (context.trigger && !["-", "="].includes(context.trigger)) {
+  if (context.trigger && !["="].includes(context.trigger)) {
     return null;
   }
 

diff --git a/server/src/providers/completion/completion-yaml.ts b/server/src/providers/completion/completion-yaml.ts
@@ -19,11 +19,6 @@ export async function yamlCompletions(context: EditorContext) {
     return null;
   }
 
-  // validate trigger
-  if (context.trigger && !["-"].includes(context.trigger)) {
-    return null;
-  }
-
   // get completions
   const result = await quarto.getYamlCompletions(context);
   if (result) {

diff --git a/server/src/providers/completion/completion.ts b/server/src/providers/completion/completion.ts
@@ -22,7 +22,7 @@ export const kCompletionCapabilities: ServerCapabilities = {
     resolveProvider: false,
     // register a superset of all trigger characters for embedded languages
     // (languages are responsible for declaring which one they support if any)
-    triggerCharacters: [".", "$", "@", ":", "\\", "-", "="],
+    triggerCharacters: [".", "$", "@", ":", "\\", "="],
   },
 };
 

diff --git a/server/src/providers/completion/refs/completion-refs.ts b/server/src/providers/completion/refs/completion-refs.ts
@@ -27,7 +27,7 @@ export async function refsCompletions(
   }
 
   // validate trigger
-  if (context.trigger && !["@", "-"].includes(context.trigger)) {
+  if (context.trigger && !["@"].includes(context.trigger)) {
     return null;
   }