Adding async_output when already running async the run call to asynci… #136
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…o.run will raise an exception.
What's in this PR?
Added a new function to _media.py called async_output
This new function internally calls the async_run instead of run. which can be awaited.
Why?
If already running within an asyncio event loop, the call under https://github.com/quasarstream/python-ffmpeg-video-streaming/blob/master/ffmpeg_streaming/_media.py#L119 will raise a RuntimeError: "asyncio.run() cannot be called from a running event loop"
A workaround for the client is to avoid the
run_command
when runningstream.output
as seen below:Which problem does the PR fix?
Example Usage