rpm: consult dnf database for repository information

[hdonnay]

These changes make the rhel machinery consult both the rpm and dnf databases when possible.

See-also: #809

[codecov]

Codecov Report

Attention: Patch coverage is 29.52381% with 74 lines in your changes missing coverage. Please review.

Project coverage is 55.23%. Comparing base (c2fc225) to head (57bb054).

Files	Patch %	Lines
rpm/dnf.go	25.71%	52 Missing ⚠️
rpm/packagescanner.go	14.28%	18 Missing ⚠️
rhel/coalescer.go	57.14%	1 Missing and 2 partials ⚠️
rpm/native_db.go	85.71%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #869      +/-   ##
==========================================
- Coverage   55.39%   55.23%   -0.17%     
==========================================
  Files         282      283       +1     
  Lines       17836    17923      +87     
==========================================
+ Hits         9881     9899      +18     
- Misses       6923     6990      +67     
- Partials     1032     1034       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[hdonnay]

• Update this to check the files for a marker value and continue if found.

Should look for from_dnf_hint key in the yaml files.
See also: containerbuildsystem/atomic-reactor#2140

[hdonnay]

Punting on this unless we determine it's needed.

[cgwalters]

I created rpm-software-management/rpm#3505 related to this

[RTann]

made it through most of the files, but I'll need to come back to this another time. Would you mind making more commits and then squashing things at the end so it's easier to see the diffs after each round? Thanks

[crozzy]

These txter test files are not net-new, I think they should be removed from rpm/testdata

[crozzy]

This will leave inconsistencies in how the repo IDs are reported in index report. Packages with no specific repos will report their repo ids as numerical with the ability to be referenced back to repository objects (like current behaviour):

        "repository_ids": [
          "1",
          "2",
...

But packages that have a specific repoid specified by the DNF DB will have the repo slug that can not be directly referenced back to a repository object:

        "repository_ids": [
          "rhel-9-for-x86_64-appstream-rpms"
        ]

We should think of a way to make these consistent to keep the expectation that "repository_ids" will refer to keys in the "repository" section and not a mix of the claircore.Repository.ID and (what will be persisted as) the claircore.Repository.Name.

[crozzy]

Could do something like this:

func lookupRepositoryID(repos []*claircore.Repository, slug string) string {
       for _, r := range repos {
               if r.Name == slug {
                       return r.ID
               }
       }
       return ""
}

and then

if slug := v.Get("repoid"); slug != "" {
    if id := lookupRepositoryID(layerArtifacts.Repos, slug); id != "" {
         environment.RepositoryIDs = []string{id}
    }

This should always find a repo as repository scanner should be finding the same repos as the package scanner.

[crozzy]

This suggestion is incomplete in that we need to append all repositories who's Name == repoid, not just the first one as the example code does