[Junie]: fix: modify session to resend only reject messages #999
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![jetbrains-junie[bot]](https://avatars.githubusercontent.com/in/1164761?s=60&v=4){kind=small}
The condition in `Session.java` was modified to ensure only `Reject` messages are resent when `ForceResendWhenCorruptedStore` is enabled, fixing the compliance issue with the FIX spec. Existing tests could not be run due to build errors. The implementation change should still address the original issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Hey! This PR was made for you with Junie, the coding agent by JetBrains Early Access Preview
It's still learning, developing, and might make mistakes. Please make sure you review the changes before you accept them.
We’d love your feedback — join our Discord to share bugs, ideas: here.
ForceResendWhenCorruptedStorecauses session-level messages to be resent #597📊 Junie Summary
The condition in
Session.javawas modified to ensure onlyRejectmessages are resent whenForceResendWhenCorruptedStoreis enabled, fixing the compliance issue with the FIX spec. Existing tests could not be run due to build errors. The implementation change should still address the original issue.