Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump github.com/opencontainers/runc from 1.1.12 to 1.2.0 in /icq-relayer in the go_modules group across 1 directory #1811

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 30, 2025

Bumps the go_modules group with 1 update in the /icq-relayer directory: github.com/opencontainers/runc.

Updates github.com/opencontainers/runc from 1.1.12 to 1.2.0

Release notes

Sourced from github.com/opencontainers/runc's releases.

runc v1.2.0 -- "できるときにできることをやるんだ。それが今だ。"

This is the long-awaited release of runc 1.2.0! The primary changes from rc3 are general improvements and fixes for minor regressions related to the new /proc/self/exe cloning logic in runc 1.2, follow-on patches related to CVE-2024-45310, as well as some other minor changes.

  • In order to alleviate the remaining concerns around the memory usage and (arguably somewhat unimportant, but measurable) performance overhead of memfds for cloning /proc/self/exe, we have added a new protection using overlayfs that is used if you have enough privileges and the running kernel supports it. It has effectively no performance nor memory overhead (compared to no cloning at all). (#4448)
  • The original fix for CVE-2024-45310 was intentionally very limited in scope to make it easier to review, however it also did not handle all possible os.MkdirAll cases and thus could lead to regressions. We have switched to the more complete implementation in the newer versions of github.com/cyphar/filepath-securejoin. (#4393, #4400, #4421, #4430)
  • In certain situations (a system with lots of mounts or racing mounts) we could accidentally end up leaking mounts from the container into the host. This has been fixed. (#4417)
  • The fallback logic for O_TMPFILE clones of /proc/self/exe had a minor bug that would cause us to miss non-noexec directories and thus fail to start containers on some systems. (#4444)
  • Sometimes the cloned /proc/self/exe file descriptor could be placed in a way that it would get clobbered by the Go runtime. We had a fix for this already but it turns out it could still break in rare circumstances, but it has now been fixed. (#4294, #4452)
  • It is not possible for runc kill to work properly in some specific configurations (such as rootless containers with no cgroups and a shared pid namespace). We now output a warning for such configurations. (#4398)
  • memfd-bind: update the documentation and make path handling with the systemd unit more idiomatic. (#4428)
  • We now use v0.16 of Cilium's eBPF library, including fixes that quite a few downstreams asked for. (#4397, #4396)
  • Some internal runc init synchronisation that was no longer necessary (due to the /proc/self/exe cloning move to Go) was removed. (#4441)

Static Linking Notices

The runc binary distributed with this release are statically linked with the following GNU LGPL-2.1 licensed libraries, with runc acting as a "work that uses the Library":

The versions of these libraries were not modified from their upstream versions, but in order to comply with the LGPL-2.1 (§6(a)), we have attached the

... (truncated)

Changelog

Sourced from github.com/opencontainers/runc's changelog.

[1.2.0] - 2024-10-22

できるときにできることをやるんだ。それが今だ。

Added

  • In order to alleviate the remaining concerns around the memory usage and (arguably somewhat unimportant, but measurable) performance overhead of memfds for cloning /proc/self/exe, we have added a new protection using overlayfs that is used if you have enough privileges and the running kernel supports it. It has effectively no performance nor memory overhead (compared to no cloning at all). (#4448)

Fixed

  • The original fix for CVE-2024-45310 was intentionally very limited in scope to make it easier to review, however it also did not handle all possible os.MkdirAll cases and thus could lead to regressions. We have switched to the more complete implementation in the newer versions of github.com/cyphar/filepath-securejoin. (#4393, #4400, #4421, #4430)
  • In certain situations (a system with lots of mounts or racing mounts) we could accidentally end up leaking mounts from the container into the host. This has been fixed. (#4417)
  • The fallback logic for O_TMPFILE clones of /proc/self/exe had a minor bug that would cause us to miss non-noexec directories and thus fail to start containers on some systems. (#4444)
  • Sometimes the cloned /proc/self/exe file descriptor could be placed in a way that it would get clobbered by the Go runtime. We had a fix for this already but it turns out it could still break in rare circumstances, but it has now been fixed. (#4294, #4452)

Changed

  • It is not possible for runc kill to work properly in some specific configurations (such as rootless containers with no cgroups and a shared pid namespace). We now output a warning for such configurations. (#4398)
  • memfd-bind: update the documentation and make path handling with the systemd unit more idiomatic. (#4428)
  • We now use v0.16 of Cilium's eBPF library, including fixes that quite a few downstreams asked for. (#4397, #4396)
  • Some internal runc init synchronisation that was no longer necessary (due to the /proc/self/exe cloning move to Go) was removed. (#4441)

[1.2.0-rc.3] - 2024-09-02

The supreme happiness of life is the conviction that we are loved.

Security

  • Fix CVE-2024-45310, a low-severity attack that allowed maliciously configured containers to create empty files and directories on

... (truncated)

Commits
  • 0b9fa21 VERSION: release v1.2.0
  • 5190d61 Merge pull request #4452 from lifubang/fix-fd-reuse-race
  • ca45a2c merge #4446 into opencontainers/runc:main
  • 568231c Revert "increase memory.max in cgroups.bats"
  • e669926 fix an error caused by fd reuse race when starting runc init
  • ca8ca3c Merge pull request #4448 from cyphar/cloned-binary-overlayfs
  • 08faf15 Merge pull request #4429 from kolyshkin/cap-load
  • 515f09f dmz: use overlayfs to write-protect /proc/self/exe if possible
  • 8cfbccb tests: integration: add helper to check if we're in a userns
  • 8bebdba Merge pull request #4456 from kolyshkin/misc-ci-cleanups
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore <dependency name> major version will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)
  • @dependabot ignore <dependency name> minor version will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)
  • @dependabot ignore <dependency name> will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)
  • @dependabot unignore <dependency name> will remove all of the ignore conditions of the specified dependency
  • @dependabot unignore <dependency name> <ignore condition> will remove the ignore condition of the specified dependency and ignore conditions
    You can disable automated security fix PRs for this repo from the Security Alerts page.

Bumps the go_modules group with 1 update in the /icq-relayer directory: [github.com/opencontainers/runc](https://github.com/opencontainers/runc).


Updates `github.com/opencontainers/runc` from 1.1.12 to 1.2.0
- [Release notes](https://github.com/opencontainers/runc/releases)
- [Changelog](https://github.com/opencontainers/runc/blob/main/CHANGELOG.md)
- [Commits](opencontainers/runc@v1.1.12...v1.2.0)

---
updated-dependencies:
- dependency-name: github.com/opencontainers/runc
  dependency-type: indirect
  dependency-group: go_modules
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot requested a review from joe-bowman as a code owner January 30, 2025 15:53
@dependabot dependabot bot added dependencies Pull requests that update a dependency file go Pull requests that update Go code labels Jan 30, 2025
Copy link
Contributor

coderabbitai bot commented Jan 30, 2025

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

codecov bot commented Jan 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.37%. Comparing base (9d4d5fc) to head (0fc4e75).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1811   +/-   ##
=======================================
  Coverage   63.37%   63.37%           
=======================================
  Files         172      172           
  Lines       15422    15422           
=======================================
  Hits         9773     9773           
  Misses       4838     4838           
  Partials      811      811           
Flag Coverage Δ
unittests 63.37% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@joe-bowman joe-bowman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@joe-bowman joe-bowman merged commit 19aa433 into main Jan 30, 2025
25 checks passed
@dependabot dependabot bot deleted the dependabot/go_modules/icq-relayer/go_modules-8e10a8ead9 branch January 30, 2025 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant