Namespaced includes #626
Merged
Namespaced includes #626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested by including all headers in the namespaced form in consumer code and building with the namespace folder removed from the search path. Also verified that an unmodified Neochat still builds fine after this. |
|
@KitsuneRal so how should we proceed with this? |
|
Upon a quick glance, I certainly like this approach over #625. I will take a closer look at it next week. |
KitsuneRal
added
enhancement
Any news on this? |
|
I tested it out with Quaternion and it actually looks quite good. Can you please resolve the conflicts (I think the only actual one is in |
KitsuneRal
reviewed
Apr 22, 2023
The include search path propagated by CMake to consumers is adjusted accordingly, so this remains source-compatible.
For this to work transparently, add the include install location to the search path as well.
Setting QUOTIENT_FORCE_NAMESPACED_INCLUDES before the find_package call will not add the namespace include dir to the search path. This isn't really elegant, but allows both retaining full source compatibility and helps consumers that have clashing include file names.
vkrause
force-pushed
the
work/vkrause/namespaced-includes
branch
from
32180f3 to
69aa818
Compare
This is necessary in order to also allow enforcing namespaced includes in embedded/inline builds of libQuotient and is cleaner to do that way then to manually mess with include search paths just for the tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the alternative approach to #625, and is source-compatible for CMake consumers.
This still needs to be checked for completeness (ie. are all headers really working in a pure namespaced use now), and needs the opt-out switch in the CMake config files, but it should hopefully be sufficient to decide on which of the approaches to take.