-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Tutorials for Circuit Renderers #102
Conversation
Why does this not trigger any tests... I remember there were tests waiting for approval when it was created. Now they disappear. |
@gadhvirushiraj Could you maybe push something, e.g. add a |
Is |
It should be supported, but I did remember making some changes on that a few weeks ago. Maybe something went wrong. What was the error? |
@gadhvirushiraj if you update your branch the tests should now run. some of the plotting stuff in old qip plotting examples now fail and need updating to the new draw() method. I tried in the other PR but these produced additional issues, so maybe better you check here (one had trouble parsing a latex label, and the other failed completely). |
This should work after qutip/qutip-qip#257 merge. |
these look good now. thanks rushi. for the v4 failing test, maybe we need to fix the numpy test environment to 1.20 or lower? |
Sorry rushi, that seemed to make things worse. can you revert that change to the numpy version, and I will see if I can produce the original problem locally. |
This reverts commit 1f50f12.
@nwlambert I have reverted the changes, but I previously verified that |
I think we can just fix it by using the right dtype in the notebook, |
latest jax release (0.4.36) breaks something in qutip-jax, but v4 tests are finally running, so will merge |
New Renderer Tutorials
GSOC'24 Project - QuTiP: Enhanced Quantum Circuit Diagrams
✅ TextRenderer Tutorial
✅ MatRenderer Tutorial