fail-safe mode (#239)

r-dbi · May 2, 2018 · add9daa · add9daa
1 parent 854e0eb
commit add9daa
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/NEWS.md b/NEWS.md
@@ -14,7 +14,8 @@
 
 ## Documentation updates
 
-- Update docs on how to cope with stored procedures (#239, @aryoda).
+- The DBI specification vignette is rendered correctly from the installed package (#234).
+- Update docs on how to cope with stored procedures (#242, @aryoda).
 - Add "Additional arguments" sections and more examples for `dbGetQuery()`, `dbSendQuery()`, `dbExecute()` and `dbSendStatement()`.
 - The `dbColumnInfo()` method is now fully specified (#75).
 - The `dbListFields()` method is now fully specified (#75).

diff --git a/R/rd.R b/R/rd.R
@@ -9,8 +9,11 @@ methods_as_rd <- function(method) {
   s4_topic <- function(x) {
     sig <- paste0(x@defined, collapse = ",")
     sig_text <- paste0('"', x@defined, '"', collapse = ", ")
-    package <- getNamespaceName(environment(x@.Data))
-    if (package == "DBI") {
+    package <- tryCatch(
+      getNamespaceName(environment(x@.Data)),
+      error = function(e) NA
+    )
+    if (is.na(package) || package == "DBI") {
       NA_character_
     } else {
       paste0(