Use a universal reserve() method
#373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #368 - this issue doesn't matter too much, but if you start as a writable ALTREP object and then call
push_back()and that resizes the vector, then it will still look like an ALTREP object even thoughRf_xlengthgets()will never produce an ALTREP object. The right thing to do is to always recompute the flag from the newly allocated object.When working on this, I realized we could unify the
reserve()methods, removing a lot of duplication, which is great. It now also sets thedata_p_for VECSXP and STRSXP which was not happening before, butget_p()will always returnnullptrfor these types, so no harm done.