Detect a non-binary body better #262
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hadley
reviewed
Aug 3, 2023
mgirlich
commented
Aug 7, 2023
| @@ -7,7 +7,7 @@ | |||
| -> Accept-Encoding: gzip | |||
| -> Content-Length: 17 | |||
| -> | |||
| >> This is some text | |||
| >> 17 bytes of binary data | |||
There was a problem hiding this comment.
This is because the check on any(x > 128). But I guess this is fine, in particular if also the content type header is consulted in a future PR.
There was a problem hiding this comment.
Ohhh, I didn't realise we weren't using the content type yet. How hard would it be to do that?
|
I'm less confident that we can get this to work without a bunch of effort — won't we need to manually parse the headers in order to figure out the content type? |
|
Closing in favour of #427 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #91.
The type resp. content type of the request/response body provides a good indicator whether the body contains binary data or not.