Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Graceful later_fd fallback if later_api.h is newer than installed later #204

Merged
merged 10 commits into from
Nov 27, 2024
Merged

Graceful later_fd fallback if later_api.h is newer than installed later #204

merged 10 commits into from
Nov 27, 2024
+52 −3

Conversation

jcheng5
Copy link
Member

@jcheng5 jcheng5 commented Nov 27, 2024 •
edited
Loading

Fixes #203

To test:

devtools::install_github("r-lib/later#204")
install.packages("promises", type="source")
devtools::install_version("later", "1.3.1")

then restart R and library(promises)

  • Un-break inst/include/later.h

@jcheng5 jcheng5 mentioned this pull request Nov 27, 2024
Closed
@jcheng5 jcheng5 marked this pull request as ready for review November 27, 2024 21:08
@shikokuchuo shikokuchuo mentioned this pull request Nov 27, 2024
Closed
shikokuchuo
shikokuchuo reviewed Nov 27, 2024
View reviewed changes
inst/include/later.h Outdated Show resolved Hide resolved
inst/include/later.h Show resolved Hide resolved
@jcheng5 jcheng5 merged commit 69721d5 into main Nov 27, 2024
17 checks passed
@jcheng5 jcheng5 deleted the later_fd_ccallable_mismatch branch November 27, 2024 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shikokuchuo shikokuchuo shikokuchuo left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error: function 'execLaterFdNative' not provided by package 'later'
2 participants
@jcheng5 @shikokuchuo