Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent logic around magrittr pipes #2046

Merged
merged 12 commits into from
Aug 7, 2023
Merged

Consistent logic around magrittr pipes #2046

merged 12 commits into from
Aug 7, 2023

Conversation

MichaelChirico
Copy link
Collaborator

Closes #2008

@codecov-commenter
Copy link

codecov-commenter commented Aug 4, 2023

Codecov Report

Merging #2046 (7c485d4) into main (191e3b7) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 7c485d4 differs from pull request most recent head fe90657. Consider uploading reports for the commit fe90657 to get more accurate results

@@           Coverage Diff           @@
##             main    #2046   +/-   ##
=======================================
  Coverage   98.56%   98.56%           
=======================================
  Files         114      114           
  Lines        5002     5008    +6     
=======================================
+ Hits         4930     4936    +6     
  Misses         72       72           
Files Changed Coverage Δ
R/brace_linter.R 100.00% <100.00%> (ø)
R/pipe_call_linter.R 100.00% <100.00%> (ø)
R/pipe_continuation_linter.R 100.00% <100.00%> (ø)
R/unnecessary_concatenation_linter.R 100.00% <100.00%> (ø)
R/unnecessary_placeholder_linter.R 100.00% <100.00%> (ø)
R/yoda_test_linter.R 100.00% <100.00%> (ø)

R/pipe_call_linter.R Show resolved Hide resolved
tests/testthat/test-unnecessary_concatenation_linter.R Outdated Show resolved Hide resolved
tests/testthat/test-unnecessary_placeholder_linter.R Outdated Show resolved Hide resolved
tests/testthat/test-yoda_test_linter.R Outdated Show resolved Hide resolved
NAMESPACE Show resolved Hide resolved
tests/testthat/test-unnecessary_placeholder_linter.R Outdated Show resolved Hide resolved
tests/testthat/test-unnecessary_placeholder_linter.R Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unnecessary_concatenation_linter wrongly complains about usage with magrittr's assignment pipe operator %<>%
3 participants