Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lint() always has message class character, not an object #2755

Merged
merged 12 commits into from
Feb 17, 2025
Merged

Lint() always has message class character, not an object #2755

merged 12 commits into from
Feb 17, 2025

Conversation

MichaelChirico
Copy link
Collaborator

Closes #2740

MichaelChirico
MichaelChirico commented Feb 14, 2025
View reviewed changes
.lintr Outdated Show resolved Hide resolved
@AshesITR
Copy link
Collaborator

Why not gracefully unclass() length-1 strings?

@MichaelChirico
Copy link
Collaborator Author

Why not gracefully unclass() length-1 strings?

my thinking is it's good discipline to avoid using glue inside the lint() loop

@MichaelChirico MichaelChirico merged commit 1062623 into main Feb 17, 2025
19 checks passed
@MichaelChirico MichaelChirico deleted the glue-obj branch February 17, 2025 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AshesITR AshesITR AshesITR approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pipe_consistency_linter() returns lint object where message has class 'glue'
2 participants
@MichaelChirico @AshesITR