-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New coalesce_linter for encouraging %||% #2767
base: main
Are you sure you want to change the base?
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't coalesce imply NULLs are replaced?
We could later expand this to Similarly the vectorized variants for dplyr |
So maybe this should just be called |
Co-authored-by: AshesITR <[email protected]>
Co-authored-by: AshesITR <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2767 +/- ##
=======================================
Coverage 99.59% 99.59%
=======================================
Files 125 126 +1
Lines 6835 6869 +34
=======================================
+ Hits 6807 6841 +34
Misses 28 28 ☔ View full report in Codecov by Sentry. |
Closes #2246. Using
coalesce_linter()
overnull_coalescing_linter()
to facilitate future extensions to other types of coalescing.