feat: Use bslib's navbar Sass variables, if present #2847
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bslib patches Bootstrap to add three Sass variables:
$navbar-bg
,$navbar-light-bg
and$navbar-dark-bg
(see e.g. bslib's Boostrap 5_variables.scss
file).This PR updates pkgdown's Sass so that
$pkgdown-navbar-bg
and$pkgdown-navbar-bg-dark
inherit the (default) values from bslib so that the same Sass variables can be used in Shiny, Quarto and pkgdown.This change shouldn't affect anyone who is already using the pkgdown Sass variables as these will take precedence over bslib's navbar bg vars.
Fixes #2703