Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get ci pipelines functional, and switch to ruff linter/formatter #264

Open
wants to merge 28 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
83af112
excluded dirs from flake8 linting
Mar 22, 2024
7f5b69c
switched to autopep8
Mar 22, 2024
33c1af9
fixed pylint pipeline
Mar 22, 2024
4796edb
fixed linting command issues
Mar 22, 2024
a1d67f6
forgot xargs and removed venv from linting
Mar 22, 2024
4dcd723
fixed styling
Mar 22, 2024
64978ed
made flake8 play nice with black
rippleFCL May 3, 2024
2aa4653
version locked ci deps
rippleFCL May 3, 2024
ea5c37d
added black pre-commit hook
rippleFCL May 3, 2024
9dba346
added other linter/formaters and version locked deps
rippleFCL May 3, 2024
e4f5d04
reordered hooks and enabled fail fast
rippleFCL May 3, 2024
3d5bd99
changed docs
rippleFCL May 3, 2024
9bec303
moved requirements file
rippleFCL May 3, 2024
fbd724c
included vscode extention in tge readme and fixed typo
rippleFCL May 3, 2024
6390b4f
added missing dependencie
rippleFCL May 3, 2024
943acb6
fixed typo
rippleFCL May 3, 2024
22962e2
removed reduandant tasks
rippleFCL May 3, 2024
fecf411
return to form
rippleFCL May 3, 2024
7c4f66f
fixed typo in readme
rippleFCL May 3, 2024
641108f
removed my stupidity and improved logging
rippleFCL May 3, 2024
0798f58
removed hacky work around
rippleFCL May 3, 2024
9d7271a
added ppylint plugin for formatting logs into a actions understandabl…
rippleFCL May 3, 2024
3d9145c
switched to linter's actions
rippleFCL May 5, 2024
7a118e2
added mypi ci pipeline
rippleFCL May 13, 2024
9bb205b
switched to ruff
rippleFCL May 13, 2024
71a8068
removed fail fast
rippleFCL May 13, 2024
6cfa6e4
added extentions.json and removed pylint
rippleFCL Jul 24, 2024
d3c4832
added mypy
rippleFCL Jul 24, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .flake8
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
[flake8]
max-line-length = 127
extend-ignore = E203, W503
max-complexity = 10
max-complexity = 10
exclude =
__pycache__
.venv
15 changes: 9 additions & 6 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,25 +17,25 @@ jobs:
# exit-zero treats all errors as warnings
flake8 . --format="::warning file=%(path)s,line=%(row)d,col=%(col)d::%(text)s" --exit-zero --max-complexity=10

lint-black:
lint-pylint:
runs-on: ubuntu-latest
steps:
- name: Checkout the repository at the current branch
uses: actions/checkout@v2
- name: Install dependencies
uses: ./.github/actions/setup
- name: Lint with black
run: black --diff .
- name: Lint with pylint
run: pylint --msg-template='::({category}) file={path},line={line},col={column}::{msg}' *; if [ $(( $? & 2 )) -eq 2 ] || [ $(( $? & 1 )) -eq 1 ] ; then exit 1; else exit 0; fi

lint-pylint:
lint-autopep8:
runs-on: ubuntu-latest
steps:
- name: Checkout the repository at the current branch
uses: actions/checkout@v2
- name: Install dependencies
uses: ./.github/actions/setup
- name: Lint with pylint
run: pylint --msg-template='::warning file={path},line={line},col={column}::{msg}' */ || exit 0
- name: Lint with autopep8
run: autopep8 --recursive --diff --exclude ".venv/**" .
tigattack marked this conversation as resolved.
Show resolved Hide resolved

lint-isort:
runs-on: ubuntu-latest
Expand All @@ -47,6 +47,9 @@ jobs:
- name: Lint with isort
run: isort --check --diff .




rippleFCL marked this conversation as resolved.
Show resolved Hide resolved
check-json:
runs-on: ubuntu-latest
steps:
Expand Down
2 changes: 1 addition & 1 deletion requirements-ci.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
black
autopep8
flake8
pylint
isort
Expand Down
Loading