-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to change MaxConcurrentReconciles via MAX_CONCURRENT_RECONCILES env variable #912
base: main
Are you sure you want to change the base?
Conversation
@AntonAleksandrov13, you must sign our contributor license agreement before your changes are merged. Click here to sign the agreement. If you are a VMware employee, read this for further instruction. |
@AntonAleksandrov13, we have received your signed contributor license agreement. The review is usually completed within a week, but may take longer under certain circumstances. Another comment will be added to the pull request to notify you when the merge can proceed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I'll merge after CI passes.
@AntonAleksandrov13, your company's legal contact did not review your signed contributor license agreement within the 14 day limit. The merge can not proceed. Click here to resign the agreement. |
@AntonAleksandrov13, we have received your signed contributor license agreement. The review is usually completed within a week, but may take longer under certain circumstances. Another comment will be added to the pull request to notify you when the merge can proceed. |
@Zerpet I see that all checks, but one went though. Do I need to do anything? |
@AntonAleksandrov13 it looks like the check for the CLA bot has not reported back to GitHub. Let me double check with a colleague, I'll circle back. |
@vmwclabot this is an obvious change |
This closes #906
Note to reviewers: remember to look at the commits in this PR and consider if they can be squashed
Note to contributors: remember to re-generate client set if there are any API changes
Summary Of Changes
MAX_CONCURRENT_RECONCILES changes MaxConcurrentReconciles in TopologyReconciler and SuperStreamReconciler