Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for SQL using pgformatter #247

Merged
merged 2 commits into from
Nov 23, 2023
Merged

Add support for SQL using pgformatter #247

merged 2 commits into from
Nov 23, 2023

Conversation

abougouffa
Copy link
Contributor

Add support for pgFormatter for sql-mode.

@abougouffa abougouffa force-pushed the feature/sql branch 2 times, most recently from 954d44a to ac0c0d6 Compare November 19, 2023 12:28
raxod502
raxod502 reviewed Nov 23, 2023
View reviewed changes
Copy link
Member

@raxod502 raxod502 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Mind adding it to the list in the changelog?

@abougouffa
Copy link
Contributor Author

@raxod502 Thanks for the feedback, done!

@abougouffa abougouffa force-pushed the feature/sql branch 2 times, most recently from ecaf199 to 3218c83 Compare November 23, 2023 21:35
@abougouffa
Copy link
Contributor Author

I've resolved merge conflicts, should be ok to merge!

raxod502
raxod502 approved these changes Nov 23, 2023
View reviewed changes
Copy link
Member

@raxod502 raxod502 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨

@raxod502 raxod502 merged commit 515ee18 into radian-software:main Nov 23, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raxod502 raxod502 raxod502 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abougouffa @raxod502